Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6892] Add error pages (404, 500) to Wordify BP #118

Merged
merged 6 commits into from
Jul 18, 2024
Merged

[6892] Add error pages (404, 500) to Wordify BP #118

merged 6 commits into from
Jul 18, 2024

Conversation

jvega190
Copy link
Member

@jvega190
Copy link
Member Author

@rart here are some screenshots for review:
Screenshot from 2024-06-18 15-06-50
404:
Screenshot from 2024-06-18 15-10-03
500:
Screenshot from 2024-06-18 15-10-47

rart
rart suggested changes Jun 21, 2024
View reviewed changes
Copy link
Member

@rart rart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to preserve header/footer?

rart
rart suggested changes Jun 21, 2024
View reviewed changes
templates/web/errors/layout.ftl Outdated Show resolved Hide resolved
@jvega190
Copy link
Member Author

Would it be possible to preserve header/footer?

Both header and footer need the model for it to render (social media items, about us content, quick links, copyright text)

@sumerjabri sumerjabri requested a review from rart June 23, 2024 05:45
rart
rart suggested changes Jul 3, 2024
View reviewed changes
templates/web/errors/layout.ftl Outdated Show resolved Hide resolved
@jvega190 jvega190 requested a review from rart July 3, 2024 16:03
sumerjabri
sumerjabri requested changes Jul 12, 2024
View reviewed changes
Copy link
Member

@sumerjabri sumerjabri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the version numbers in craftercms-plugin.yaml. If this doesn't break compatibility, then just bump the BP version number.

@jvega190
Copy link
Member Author

@sumerjabri version updated, compatibility stays the same

@jvega190 jvega190 requested a review from sumerjabri July 12, 2024 17:14
@sumerjabri sumerjabri merged commit 9b38f7f into craftercms:next Jul 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rart rart rart approved these changes

@sumerjabri sumerjabri sumerjabri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvega190 @rart @sumerjabri